Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added probing environments tests on A2C #332

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

YannBerthelot
Copy link
Collaborator

Description

Add probing environments tests in the units tests of the library.
The goal is to easily and quickly identify which parts of an agent may be faulty when results are incorrect. This is only meant to be used in tests.

Required dependency is : https://github.com/YannBerthelot/ProbingEnvironments

@KohlerHECTOR KohlerHECTOR added this to In progress in Marathon rlberry Jul 13, 2023
@KohlerHECTOR KohlerHECTOR added the Marathon To do during Marathon label Jul 13, 2023
@RemyDegenne RemyDegenne moved this from In progress to Ready for review in Marathon rlberry Jul 24, 2023
@JulienT01
Copy link
Collaborator

Hello Yann !

If these tests are specific to A2C, can you move them to this file => rlberry/agents/torch/tests/test_a2c.py
If they can be generalized to other agents, try doing it like in /rlberry/tests/test_agent_extra.py (and move them to this file).

Thanks for these tests!

@TimotheeMathieu TimotheeMathieu removed this from Ready for review in Marathon rlberry Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Marathon To do during Marathon ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants