forked from adobe/react-spectrum
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus Management within Shadow DOM #1
Draft
MahmoudElsayad
wants to merge
204
commits into
shadow-dom-base-branch
Choose a base branch
from
shadow-dom-enhancement-1-getRootNode
base: shadow-dom-base-branch
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Focus Management within Shadow DOM #1
MahmoudElsayad
wants to merge
204
commits into
shadow-dom-base-branch
from
shadow-dom-enhancement-1-getRootNode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ts diff
* Image - add support for onerror callback * Image - add support for onerror callback * chore: add test case and update image stories * chore: fix build * chore: fix lint * chore: fix lint * Update packages/@react-types/image/src/index.d.ts Co-authored-by: Reid Barber <reid@reidbarber.com> * chore: fix types * chore: doc updated * chore: fix doc examples * chore: add support for onLoad callback * chore: add support for onLoad callback * chore: add support for onLoad callback * chore: add support for onLoad callback * chore: add support for onLoad callback * Update packages/@react-types/image/src/index.d.ts Co-authored-by: Robert Snow <snowystinger@gmail.com> * Update packages/@react-types/image/src/index.d.ts Co-authored-by: Robert Snow <snowystinger@gmail.com> * chore: resolve comment- update docs * small updates * fix lint --------- Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
* Allow passing of inputRef to RAC Checkbox/Switch * make optional, add tests * merge refs * fix ts? * fix/update tests * move declaration of inputRef * add doc comments * remove defaultInputRef --------- Co-authored-by: Devon Govett <devongovett@gmail.com>
* fix onBlur in Combobox when no Button * fix after review * fix undefined ref value * Update packages/@react-aria/combobox/test/useComboBox.test.js --------- Co-authored-by: Robert Snow <snowystinger@gmail.com>
…#6018) * add ContextualHelp example for disabled button to Tooltip * Update Tooltip.mdx Co-authored-by: Robert Snow <rsnow@adobe.com> * Update Tooltip.mdx Co-authored-by: Robert Snow <rsnow@adobe.com> --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
…5986) Co-authored-by: Daniel Lu <dl1644@gmail.com>
* Change useMenuTrigger onPressStart to state.open * add test --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
Update domHelpers.test.js.
escape <form> in ButtonProps for jsdocs (adobe#6041)
add HoverEvents type to ToggleButtonProp type
Add Tests for FocusScope.test.js. New helper util `getRootBody`.
Co-authored-by: Reid Barber <reid@reidbarber.com>
Fix `useRestoreFocus` issue. Add new DOM util `getDeepActiveElement`.
… navigation example`.
update `useFocus` - `useFocusWithin` - `usePress`.
Test for `focusSafely`.
adobe#6325)" (adobe#6407) This reverts commit 122d0c8.
…dobe#6379) * Remove `@swc/helpers` dependency from `@react-stately/flags` Closes adobe#6378 * Update package.json Meet requirement for having a dep on swc helpers --------- Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
Fix correctly handle IME Input in Combobox
…#6324) Fix buttons inside disabled grid list items not being disabled (adobe#6324)
Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
Co-authored-by: Robert Snow <rsnow@adobe.com>
Add inputRef support for RAC SliderThumb
…dobe#6219) * nonce parameter for Content Security Policy
add ResizeObserver that observes targetRef
fix react hook form example
Make `useSearchField` behave close to browser
* Fix Menu Section aria-label
…true (adobe#6209) * Prevent default when the submit button is clicked while isPending is true * prevent default for all button types --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
Co-authored-by: Reid Barber <reid@reidbarber.com>
Co-authored-by: Robert Snow <snowystinger@gmail.com>
Co-authored-by: Robert Snow <snowystinger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes adobe#1472
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: