Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus Management within Shadow DOM #1

Draft
wants to merge 204 commits into
base: shadow-dom-base-branch
Choose a base branch
from

Conversation

MahmoudElsayad
Copy link
Collaborator

@MahmoudElsayad MahmoudElsayad commented Mar 11, 2024

Closes adobe#1472

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

devongovett and others added 30 commits March 6, 2024 10:12
* Image - add support for onerror callback

* Image - add support for onerror callback

* chore: add test case and update image stories

* chore: fix build

* chore: fix lint

* chore: fix lint

* Update packages/@react-types/image/src/index.d.ts

Co-authored-by: Reid Barber <reid@reidbarber.com>

* chore: fix types

* chore: doc updated

* chore: fix doc examples

* chore: add support for onLoad callback

* chore: add support for onLoad callback

* chore: add support for onLoad callback

* chore: add support for onLoad callback

* chore: add support for onLoad callback

* Update packages/@react-types/image/src/index.d.ts

Co-authored-by: Robert Snow <snowystinger@gmail.com>

* Update packages/@react-types/image/src/index.d.ts

Co-authored-by: Robert Snow <snowystinger@gmail.com>

* chore: resolve comment- update docs

* small updates

* fix lint

---------

Co-authored-by: Reid Barber <reid@reidbarber.com>
Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Robert Snow <snowystinger@gmail.com>
* Allow passing of inputRef to RAC Checkbox/Switch

* make optional, add tests

* merge refs

* fix ts?

* fix/update tests

* move declaration of inputRef

* add doc comments

* remove defaultInputRef

---------

Co-authored-by: Devon Govett <devongovett@gmail.com>
* fix onBlur in Combobox when no Button

* fix after review

* fix undefined ref value

* Update packages/@react-aria/combobox/test/useComboBox.test.js

---------

Co-authored-by: Robert Snow <snowystinger@gmail.com>
…#6018)

* add ContextualHelp example for disabled button to Tooltip

* Update Tooltip.mdx

Co-authored-by: Robert Snow <rsnow@adobe.com>

* Update Tooltip.mdx

Co-authored-by: Robert Snow <rsnow@adobe.com>

---------

Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Daniel Lu <dl1644@gmail.com>
* Change useMenuTrigger onPressStart to state.open

* add test

---------

Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Reid Barber <reid@reidbarber.com>
Update domHelpers.test.js.
escape <form> in ButtonProps for jsdocs (adobe#6041)
add HoverEvents type to ToggleButtonProp type
Add Tests for FocusScope.test.js.
New helper util `getRootBody`.
Co-authored-by: Reid Barber <reid@reidbarber.com>
Fix `useRestoreFocus` issue.
Add new DOM util `getDeepActiveElement`.
update `useFocus` - `useFocusWithin` - `usePress`.
Test for `focusSafely`.
MahmoudElsayad and others added 30 commits May 20, 2024 05:33
…dobe#6379)

* Remove `@swc/helpers` dependency from `@react-stately/flags`

Closes adobe#6378

* Update package.json

Meet requirement for having a dep on swc helpers

---------

Co-authored-by: Robert Snow <snowystinger@gmail.com>
Co-authored-by: Daniel Lu <dl1644@gmail.com>
Fix correctly handle IME Input in Combobox
…#6324)

Fix buttons inside disabled grid list items not being disabled (adobe#6324)
Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
Co-authored-by: Robert Snow <rsnow@adobe.com>
Add inputRef support for RAC SliderThumb
add ResizeObserver that observes targetRef
fix react hook form example
Make `useSearchField` behave close to browser
* Fix Menu Section aria-label
…true (adobe#6209)

* Prevent default when the submit button is clicked while isPending is true

* prevent default for all button types

---------

Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Daniel Lu <dl1644@gmail.com>
Co-authored-by: Reid Barber <reid@reidbarber.com>
Co-authored-by: Robert Snow <snowystinger@gmail.com>
Co-authored-by: Robert Snow <snowystinger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet