Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed persisted viewmodel in Chrome #686

Closed

Conversation

GerardSmit
Copy link

See #685 for more information. Maybe we should add an setting in DotvvmConfiguration to configure this behaviour incase someone uses an element selector that searches for input[type=hidden] in his code.


fixes #685

Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me (although I'd be happier if the hidden field worked in Chrome...).

I don't think we need the configuration option, there is no reason to find that element by type when it has id="__dot_viewmodel_root"

@GerardSmit
Copy link
Author

Actually, I just realized that input[type=input] can have issues with autocomplete. Maybe we should add the attribute autocomplete=off on the input just to be sure.

@GerardSmit
Copy link
Author

This solution will be re-written with the History API, see #685 (comment) for more information.

@GerardSmit GerardSmit closed this Apr 26, 2019
@GerardSmit GerardSmit deleted the fix/chrome-persisted-viewmodel branch April 26, 2019 11:40
@GerardSmit GerardSmit restored the fix/chrome-persisted-viewmodel branch April 26, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome doesn't remember viewmodel after history change
2 participants