Use System.Text.Json as a backend for view model serialization #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
requested changes
Apr 15, 2024
src/Framework/Framework/Binding/Expressions/BindingDebugJsonConverter.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Binding/Expressions/BindingDebugJsonConverter.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Binding/Expressions/CommandBindingExpression.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/ResourceManagement/ReflectionAssemblyJsonConverter.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/ResourceManagement/ReflectionAssemblyJsonConverter.cs
Outdated
Show resolved
Hide resolved
| throw new NotSupportedException(string.Format("resource collection name {0} is not supported", prop.Key)); | ||
| } | ||
| return repo; | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Ask if VS Extension needs this
| return rt; | ||
| } | ||
| throw new NotImplementedException(); | ||
| // var rt = new DotvvmRouteTable(); |
There was a problem hiding this comment.
Ask if VS extension needs this.
src/Framework/Framework/Runtime/Tracing/RequestTracingExtensions.cs
Outdated
Show resolved
Hide resolved
* fix debug JsonConverters (must be factories to accomodate derived types) * add charset=utf8 to all returned Content-Types * DiagnosticsRequestTracer.ViewModelSerialized now accepts Func<Stream> * Removed viewmodel_stringification_seconds metric as it is no longer relevant (serialization and stringification are now the same thing) * add some [doc]comments
Just to avoid balooning this monster PR. This specific feature is also likely to be removed, depending on the answer from VS Extension guys.
It is neccessary in order to support IGridViewDataSet type hierarchy. The issue didn't occur before, because we didn't map interface correctly, ignoring inherited properties. It didn't matter, because we never serialized them. Now we can end up serializing interface if DynamicDispatch is disabled. The shadowing allows redefining a property with another property of the same .NET Name with a compatible type.
Not needed anymore, the types are natively supported by the serialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All UI tests are currently passing (on Asp.Net Core), most unit tests pass on both .NET Core and .NET Framework, Owin UI tests do not start because of some assembly version conflicts.
Changes to Samples and UI tests are minimal (only dependency version changes, as this requires System.Text.Json 8):