Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property directive compilation extensibility improvements #1771

Merged
merged 3 commits into from Feb 28, 2024

Conversation

Mylan719
Copy link
Contributor

@Mylan719 Mylan719 commented Feb 9, 2024

The generation of control wrapper type for markup controls with properties was moved to PropertyDeclarationDirectiveCompiler and ResolvedPropertyDeclarationDirectiveCompiler.
The reason is that on VS Extension side it is required to generate dynamic type with the control properties. This makes implementing intellisense easier.

now the compilation goes like this:

  • compile @import directives
  • based on @baseType directive with imports create intermediate wrapper type
  • Compile @property directives and if any generate custom type based on intermediate wrapper type
  • use new wrapper type down the line

@Mylan719 Mylan719 added this to the Version 4.3 milestone Feb 9, 2024
@Mylan719 Mylan719 requested a review from exyi February 9, 2024 14:57
@Mylan719 Mylan719 self-assigned this Feb 9, 2024
@Mylan719 Mylan719 force-pushed the property-compilation-improvements branch from bc40dcc to c34c075 Compare February 27, 2024 23:13
@exyi exyi merged commit 88ffbf6 into main Feb 28, 2024
15 of 16 checks passed
@exyi exyi deleted the property-compilation-improvements branch February 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants