Refactor compilation diagnostics, add them to compilation status page #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
compilation-page-warnings
branch
from
8960070
to
ba1e8dc
Compare
|
I have also added logging of compilation of error, in addition to the warnings added in #1659 |
exyi
force-pushed
the
compilation-page-warnings
branch
2 times, most recently
from
9cab783
to
1f548e9
Compare
This is a large commit of various interdependent changes with
the simple goal of adding warnings to the compilation status page.
* Non-critical errors from tokens are now reported as warnings.
Before, they were ignored completely.
* Added IDiagnosticsCompilationTracer interface
- it allows watching the compilation process, for example
observing changes made by various visitors or
in this case getting the warnings when the compilation
otherwise succeeds
* Added DotvvmCompilationDiagnostic and
DotvvmCompilationSourceLocation records
- it designed to be a generic class for warnings and errors from
the DotHTML compilation. It contains references to the syntax
and resolved trees, so it should not be stored long-term, but
provides all the possible detail about each reported error/warning.
* BindingCompilationException is refactored to use the
DotvvmCompilationDiagnostics and support any number of them.
- plus, IDotvvmException compatibility is added
- the exception will present as the "first" / primary error for better compatibility
* ErrorCheckingVisitor is now smarter about binding errors,
the BindingToken ranges are mapped into the DothtmlToken
so we can underline only the affected part of the binding.
This is somewhat important for displaying diagnostics
of multiline bindings in the compilation page.
Multiple errors can be collected from the error.
* ViewCompilationService now collects the warnings and errors
from the tracer and DotvvmCompilationException
* And finally, the compilation displays up to 8 errors and warnings
encountered during the page compilation under each row.
Warnings tab was also added which shows only the views with at
least one warning/error
exyi
force-pushed
the
compilation-page-warnings
branch
from
1f548e9
to
bccb5e6
Compare
tomasherceg
approved these changes
Jan 31, 2024
| ex.FileName = Path.Combine( | ||
| file.FullPath.Remove(file.FullPath.Length - file.FileName.Length), | ||
| ex.FileName); | ||
| fileName = Path.Combine(file.FullPath.Remove(file.FullPath.Length - file.FileName.Length), fileName); |
There was a problem hiding this comment.
This will break if the FullPath does not end with FileName
src/Framework/Framework/Compilation/DotvvmCompilationDiagnostic.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Compilation/ViewCompiler/DefaultViewCompiler.cs
Outdated
Show resolved
Hide resolved
src/Framework/Framework/Configuration/DotvvmCompilationPageConfiguration.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,14 @@ | |||
| <%-- @property DotVVM.Framework.Compilation.DotHtmlFileInfo.CompilationDiagnosticViewModel Diagnostic --%> | |||
exyi
force-pushed
the
compilation-page-warnings
branch
from
5f93303
to
f056894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large commit of various interdependent changes with the simple goal of adding warnings to the compilation status page.