Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extensibility point to provide custom fetch implementation #1339

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomasherceg
Copy link
Member

I am not sure if it is a good idea to provide this extensibility point in the public API, but the attacker can replace window.fetch anyway so it's probably not such a big deal.
Alternatively, we can bundle a special version of DotVVM for the MAUI hosted version - what do you think?

@tomasherceg tomasherceg marked this pull request as draft March 29, 2022 19:34
@exyi
Copy link
Member

exyi commented Mar 30, 2022

I'd vote for bundling special version for the MAUI, I'd guess this might not be the last thing needed there. I don't really like adding features which will never be needed in most apps and this unnecessarily increasing the bundle size (although this isn't a large change, so whatever)

@tomasherceg
Copy link
Member Author

I've done this as part of this draft PR #1368.

Depends on #1329 which should be merged first.

I've put there only the necessary things for DotVVM app to run inside WebView - the other things are still in the external repo but I plan to integrate it into DotVVM repository soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants