Merge pull request #1790 from riganti/fix-js-memberaccessindexer

JS translator: fix member access formatted as indexer
riganti · Mar 8, 2024 · cae2bbe · cae2bbe
2 parents 9b5f9dd + 6bc3634
commit cae2bbe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Framework/Framework/Compilation/Javascript/JsFormattingVisitor.cs b/src/Framework/Framework/Compilation/Javascript/JsFormattingVisitor.cs
@@ -192,7 +192,7 @@ public void VisitMemberAccessExpression(JsMemberAccessExpression memberAccessExp
         {
             EmitComment(memberAccessExpression.CommentBefore);
             if (!memberAccessExpression.MemberNameToken.IsValidName())
-                new JsIndexerExpression(memberAccessExpression.Target.Clone(), new JsLiteral(memberAccessExpression.MemberNameToken))
+                new JsIndexerExpression(memberAccessExpression.Target.Clone(), new JsLiteral(memberAccessExpression.MemberName))
                 .AcceptVisitor(this);
             else
             {

diff --git a/src/Tests/Runtime/JavascriptCompilation/JsFormatterTests.cs b/src/Tests/Runtime/JavascriptCompilation/JsFormatterTests.cs
@@ -29,6 +29,12 @@ public void JsFormatter_MemberAccess()
             AssertFormatting("a.b.c", new JsIdentifierExpression("a").Member("b").Member("c"));
         }
 
+        [TestMethod]
+        public void JsFormatter_MemberAccessIndexer()
+        {
+            AssertFormatting("a['']['some-name'].if.$type['12']['1x']['a\u200Bb']".Replace('\'', '"'), new JsIdentifierExpression("a").Member("").Member("some-name").Member("if").Member("$type").Member("12").Member("1x").Member("a\u200Bb"));
+        }
+
         [TestMethod]
         public void JsFormatter_Invocation()
         {