improve http context operations for telemetry

riganti · Apr 22, 2024 · 19dbeed · 19dbeed
1 parent 7ced2df
commit 19dbeed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/Tracing/ApplicationInsights.AspNetCore/OperationNameTelemetryInitializer.cs b/src/Tracing/ApplicationInsights.AspNetCore/OperationNameTelemetryInitializer.cs
@@ -17,10 +17,11 @@ public OperationNameTelemetryInitializer(IHttpContextAccessor accessor)
 
     public void Initialize(ITelemetry telemetry)
     {
-        var url = _accessor.HttpContext?.GetDotvvmContext()?.Route?.Url;
-        if (string.IsNullOrWhiteSpace(url) == false && telemetry is RequestTelemetry)
+        var context = _accessor.HttpContext;
+        var url = context?.GetDotvvmContext()?.Route?.Url;
+        if (url != null && telemetry is RequestTelemetry)
         {
-            var method = _accessor.HttpContext.Request.Method;
+            var method = context.Request.Method;
             var operationName = $"{method} /{url}";
 
             var requestTelemetry = telemetry as RequestTelemetry;

diff --git a/src/Tracing/ApplicationInsights.Owin/OperationNameTelemetryInitializer.cs b/src/Tracing/ApplicationInsights.Owin/OperationNameTelemetryInitializer.cs
@@ -10,10 +10,11 @@ public class OperationNameTelemetryInitializer : ITelemetryInitializer
 {
     public void Initialize(ITelemetry telemetry)
     {
-        var url = HttpContext.Current?.GetOwinContext()?.GetDotvvmContext()?.Route?.Url;
-        if (string.IsNullOrWhiteSpace(url) == false && telemetry is RequestTelemetry)
+        var context = HttpContext.Current;
+        var url = context?.GetOwinContext()?.GetDotvvmContext()?.Route?.Url;
+        if (url != null && telemetry is RequestTelemetry)
         {
-            var method = HttpContext.Current.Request.HttpMethod;
+            var method = context.Request.HttpMethod;
             var operationName = $"{method} /{url}";
 
             var requestTelemetry = telemetry as RequestTelemetry;