Skip to content

New dot:ModalDialog control, wrapper for <dialog> #2913

New dot:ModalDialog control, wrapper for <dialog>

New dot:ModalDialog control, wrapper for <dialog> #2913

Triggered via pull request February 23, 2024 18:54
@exyiexyi
synchronize #1776
modal-dialog
Status Cancelled
Total duration 4m 58s
Artifacts

main.yml

on: pull_request
Build all projects without errors
4m 32s
Build all projects without errors
JS unit tests
58s
JS unit tests
Matrix: Build published projects without warnings
Matrix: .NET unit tests
Matrix: UI tests
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 26 warnings
SerializeDefaultConfig: src/Tests/Runtime/ConfigurationSerializationTests.cs#L69
Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception: System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json index b1389e9..4f5cde2 100644 --- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json +++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json @@ -1188,7 +1188,6 @@ }, "Open": { "type": "System.Object", - "defaultValue": false, "onlyBindings": true } }, Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
.NET unit tests (ubuntu-latest)
Process completed with exit code 1.
SerializeDefaultConfig: src/Tests/Runtime/ConfigurationSerializationTests.cs#L69
Test method DotVVM.Framework.Tests.Runtime.ConfigurationSerializationTests.SerializeDefaultConfig threw exception: System.Exception: ConfigurationSerializationTests.SerializeDefaultConfig.json has changed, the actual output differs from the previous accepted output: diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json index b1389e9..4f5cde2 100644 --- a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json +++ b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json @@ -1188,7 +1188,6 @@ }, "Open": { "type": "System.Object", - "defaultValue": false, "onlyBindings": true } }, Is this change OK? To let the test pass, stage the file in git. Confused? See https://github.com/exyi/CheckTestOutput/blob/master/trouble.md#changed-file
.NET unit tests (macOS-latest)
Process completed with exit code 1.
Build all projects without errors
The run was canceled by @exyi.
UI tests (chrome, windows-2022, Development, Default)
The run was canceled by @exyi.
.NET unit tests (windows-2022)
The run was canceled by @exyi.
UI tests (firefox, ubuntu-latest, Development, Default)
The run was canceled by @exyi.
UI tests (firefox, ubuntu-latest, Production, Default)
The run was canceled by @exyi.
UI tests (chrome, ubuntu-latest, Production, Default)
The run was canceled by @exyi.
JS unit tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS unit tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
.NET unit tests (ubuntu-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (ubuntu-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (ubuntu-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (ubuntu-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (ubuntu-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, nuget/setup-nuget@v1, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build published projects without warnings (Debug)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Debug)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Debug)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Debug)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Debug)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Debug)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, nuget/setup-nuget@v1, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build published projects without warnings (Release)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Release)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Release)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Release)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Release)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build published projects without warnings (Release)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, nuget/setup-nuget@v1, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
.NET unit tests (macOS-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (macOS-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (macOS-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (macOS-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (macOS-latest)
The target framework 'netcoreapp3.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
.NET unit tests (macOS-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, nuget/setup-nuget@v1, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.