-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test Against Geos Versions #362
Open
keithdoggett
wants to merge
25
commits into
main
Choose a base branch
from
ci/multiple-geos-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
106e9fc
Test against Geos versions
keithdoggett 057f3cb
fix typo
keithdoggett 12293aa
fix minitest class naming
keithdoggett 5c2f17a
temporarily cut down on build targets
keithdoggett b277fc4
no sudo on cmake install
keithdoggett 903e10b
update ci
keithdoggett 90284a9
ldconfig after install
keithdoggett 2b6c566
Merge branch 'main' into ci/multiple-geos-versions
keithdoggett 09bb915
add version conditional to test_invalid_polygon_duplicate_rings
keithdoggett 08797ae
fix gem version matching
keithdoggett b5a5d94
debug
keithdoggett c771098
move validity tests failing specifically due to geos versions to CAPI…
keithdoggett 60134db
add macos and other ruby versions back to matrix
keithdoggett 832d4bc
ldconfig only on linux
keithdoggett fae75b4
force reinstall cmake on macos
keithdoggett 78c9947
debug macos build
keithdoggett 2a5d46e
rm debug
keithdoggett 4bb4d96
reinstall cmake
keithdoggett aab2b28
update brew in macos ci
keithdoggett e6eaf56
upgrade brew
keithdoggett fda17d1
upgrade brew
keithdoggett 5863c32
explicitly set GEOS_LIBRARY_PATH on macos jruby builds
keithdoggett 5a15dff
add more debug info
keithdoggett 2f89a31
add yqq flag
keithdoggett 0d2e457
Only test ubuntu against multiple geos versions
keithdoggett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried on my mac, and I didn't need this
GEOS_LIBRARY_PATH
variable in my path.Although my geos installation is done through homebrew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I'll try again I'm pretty stumped as to why this it isn't recognizing Geos. I shouldn't have to specify a path but clearly something's not configured correctly.