Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lint/MissingSuper rubocop offense #352

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 4
Lint/MissingSuper:
Exclude:
- 'lib/rgeo/coord_sys/cs/entities.rb'

# Offense count: 3
Lint/NonLocalExitFromIterator:
Exclude:
Expand Down
1 change: 1 addition & 0 deletions History.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* Add `transform` method to `Geometry`. #342
* Fix rubocop_todos and other refactoring. (@thestelz) #338
* Fix Style/OptionalBooleanParameter from rubocop_todos. (@haroon26) #349
* Fix Lint/MissingSuper from rubocop_todos. (@haroon26) #352

**Bug Fixes**

Expand Down
4 changes: 4 additions & 0 deletions lib/rgeo/coord_sys/cs/entities.rb
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ class AxisInfo < Base
# :startdoc:

def initialize(name, orientation) # :nodoc:
super()
@name = name
@orientation =
case orientation
Expand Down Expand Up @@ -302,6 +303,7 @@ def wkt_content(_)
# system that the projected coordinate system is based on.
class ProjectionParameter < Base
def initialize(name, value) # :nodoc:
super()
@name = name
@value = value.to_f
end
Expand Down Expand Up @@ -339,6 +341,7 @@ def wkt_content(_)
# points East, and the Z axis points North.
class WGS84ConversionInfo < Base
def initialize(dx_meters, dy_meters, dz_meters, ex_arc_seconds, ey_arc_seconds, ez_arc_seconds, ppm) # :nodoc:
super()
@dx = dx_meters.to_f
@dy = dy_meters.to_f
@dz = dz_meters.to_f
Expand Down Expand Up @@ -427,6 +430,7 @@ def create(dx_meters, dy_meters, dz_meters, ex_arc_seconds, ey_arc_seconds, ez_a
class Info < Base
def initialize(name, authority = nil, authority_code = nil, abbreviation = nil, init_alias = nil,
remarks = nil, extensions = nil) # :nodoc:
super()
@name = name
@authority = authority ? authority.to_s : nil
@authority_code = authority_code ? authority_code.to_s : nil
Expand Down