Tackle rubocop todo list

[BuonOmo]

The .rubocop_todo.yml file needs to be taken care of. Any PR in that regard is welcome!

[thestelz]

So I was going to take a stab at this, but I either have an issue with my environment or something is wrong with the gemspec.

I ran rubocop and got:

Error: unrecognized cop or department Layout/LineContinuationLeadingSpace found in .rubocop.yml
Did you mean `Layout/MultilineOperationIndentation`?

I then wanted to confirm the right version of rubocop that was installed:

rubocop -v
1.28.2

That is when I realized that in the gemspec, it has spec.add_development_dependency "rubocop", "~> 1.36.0", so I ran a bundle install. Then got:

bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundler could not find compatible versions for gem "ruby":
  In Gemfile:
    ruby

    rgeo was resolved to 3.0.0.pre.rc.3, which depends on
      ruby (>= 2.5.0)

    rubocop (~> 1.36.0) was resolved to 1.36.0, which depends on
      ruby (>= 2.6.0)

In the gemspec it has spec.required_ruby_version = ">= 2.5.0", so should that be bumped up or am I doing something incorrectly?

On a side note, it doesn't appear I can install 2.6.0 either, but that might be an issue with my system.

rbenv install 2.6.0
Downloading ruby-2.6.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.0.tar.bz2
Installing ruby-2.6.0...

BUILD FAILED (macOS 12.6 using ruby-build 20211227)

Inspect or clean up the working tree at /var/folders/s7/ghx09h6s7j7flwp1hvjmqsp00000gn/T/ruby-build.20221014122627.85939.xRPfVh
Results logged to /var/folders/s7/ghx09h6s7j7flwp1hvjmqsp00000gn/T/ruby-build.20221014122627.85939.log

Last 10 log lines:
transform_mjit_header: SKIPPED to transform __inline_isfinitel
transform_mjit_header: SKIPPED to transform __inline_isfinited
transform_mjit_header: SKIPPED to transform __inline_isfinitef
transform_mjit_header: SKIPPED to transform __darwin_fd_clr
transform_mjit_header: SKIPPED to transform __darwin_fd_set
transform_mjit_header: SKIPPED to transform __darwin_fd_isset
transform_mjit_header: SKIPPED to transform __darwin_check_fd_set
transform_mjit_header: SKIPPED to transform __sputc
transdb.h updated
ln -sf ../../../.ext/include/-darwin21/rb_mjit_min_header-2.6.0.h include/ruby-2.6.0/-darwin21/rb_mjit_min_header-2.6.0.h

[BuonOmo]

Thank you very much for working on that!

In the gemspec it has spec.required_ruby_version = ">= 2.5.0", so should that be bumped up or am I doing something incorrectly?

You can definitely bump that to 2.6.0, maybe even 2.7.0 since 2.6 is now past EOL. @keithdoggett would that be good for you ?

On a side note, it doesn't appear I can install 2.6.0 either, but that might be an issue with my system.

You should hopefully be good with at least ruby 2.7. But you're making a good case here, I think you should try ruby 2.7, 3.0, 3.1 and 3.2 with rubocop when doing the PR to ensure that it is always fine. Although, this is not mandatory at all.

[thestelz]

It appears something might be wrong with my setup

ruby -v
dyld[18069]: Library not loaded: '/usr/local/opt/gmp/lib/libgmp.10.dylib'
  Referenced from: '/Users/andrew/.rbenv/versions/2.7.2/bin/ruby'
  Reason: tried: '/usr/local/opt/gmp/lib/libgmp.10.dylib' (no such file), '/usr/local/lib/libgmp.10.dylib' (no such file), '/usr/lib/libgmp.10.dylib' (no such file)
zsh: abort      ruby -v

I'll see if I can figure out what is going on here and hopefully be able to get this issue taken care of.

[keithdoggett]

Thanks for taking a look at this!

@BuonOmo I agree if it's past EOL we shouldn't worry about supporting it IMO.