-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 stable #388
Merged
Merged
8.0 stable #388
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3efbe53
Fix tests with to_s comparison
Beardev118 0c2cdc3
Merge pull request #1 from Beardev118/fix/to_s-8.0
Beardev118 1425e2e
Fixed point object compare issue
Beardev118 30d8b73
Merge pull request #2 from Beardev118/fix/to_s-8.0
Beardev118 9ffd4f8
Removed MyPolygon class and fixed object directly compare issue
Beardev118 6f1aac1
Merge pull request #3 from Beardev118/fix/to_s-8.0
Beardev118 d8c37a5
Minor change
Beardev118 446a4a3
Merge pull request #4 from Beardev118/fix/to_s-8.0
Beardev118 0301e1e
updated the factory for srid match
Beardev118 0d2d500
Merge pull request #5 from Beardev118/fix/to_s-8.0
Beardev118 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,7 +106,8 @@ def test_set_point_wkt_wrong_type | |
def test_default_value | ||
create_model | ||
obj = SpatialModel.create | ||
assert_equal factory.point(0, 0).to_s, obj.default_latlon.to_s | ||
assert_equal factory.point(0, 0).x, obj.default_latlon.x | ||
assert_equal factory.point(0, 0).y, obj.default_latlon.y | ||
end | ||
|
||
def test_custom_factory | ||
|
@@ -122,7 +123,9 @@ def test_custom_factory | |
object.area = area | ||
object.save! | ||
object.reload | ||
assert_equal area.to_s, object.area.to_s | ||
area_p = MyPolygon.new(area) | ||
obj_area_p = MyPolygon.new(object.area) | ||
assert_equal area_p, obj_area_p | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We also need to change this back to comparing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated |
||
end | ||
|
||
def test_spatial_factory_attrs_parsing | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bigger issue we're trying to look at here is that we should be able to compare by rgeo objects and not their attributes.
should work but it's not for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this issue