Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass new identity attribute to preserve argument order #385

Merged
merged 2 commits into from Oct 16, 2023

Conversation

joseramonc
Copy link
Contributor

@joseramonc joseramonc commented Oct 12, 2023

rails/rails#49504 introduced a new identity argument on the ActiveRecord::ConnectionAdapters::PostgreSQL::Column#initialize method which is causing the dumping of virtual columns to be treated as identity columns.

This PR updates the methods to match the new ones on the Postgres adapter.

@keithdoggett
Copy link
Member

Thanks @joseramonc LGTM!

@keithdoggett keithdoggett merged commit 75dc149 into rgeo:master Oct 16, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants