Virtual column schema dump - default_function - Bring in recent postgressql adaptor change #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched from the official postgressql adaptor to this adaptor, and noticed that some virtual columns in my database started schema dumping incorrectly. In particular the
as
function would dump as nilI did some investigation and it looks like your adaptor is missing a recent change @fatkodima made that fixes this issue. here
rails/rails@7fa2720
I copied his change and added a spec to cover the scenario. I tried to do my best to adhere to the style and format of the existing tests, but can make additional changes if needed.
Thank you for your work on this project.