-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
truly support pydantic v2 without shims #1662
base: main
Are you sure you want to change the base?
Conversation
f9bd152
to
ca18776
Compare
11aea8c
to
d01d74a
Compare
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
…low for a value of None. It does not mean that the field has a default value of None. (This is a breaking change from V1.) Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
4583599
to
6254d76
Compare
…ctly Signed-off-by: technillogue <technillogue@gmail.com>
… and generating schemas Signed-off-by: technillogue <technillogue@gmail.com>
3caf4d3
to
0ca90d1
Compare
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
0ca90d1
to
2fa64fa
Compare
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
The annotation is hopeless, Tests in the commit before that are mainly failing because of openapi schema changes in 3.1.0: |
thanks! unfortunately CI only shows the tip of the iceberg. this PR should ideally figure out how to test this with both old and new pydantic, because those have completely different pytest errors. there is something completely incorrect about the v2 validators. some of the main errors that I don't know how to approach are:
|
to avoid vendoring or forking fastapi, we need to actually use the v2 pydantic models. this aims to detect which pydantic version is used and reimplement cog types for pydantic 2