Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom artifact notice #28957

Merged
merged 11 commits into from
May 16, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 9, 2024

Changes

  • Add new artifactNotice field that could be optionally returned with successful file modification

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from rarkins and viceice May 9, 2024 17:33
@rarkins
Copy link
Collaborator

rarkins commented May 10, 2024

Reproduction link?

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zharinov
Copy link
Collaborator Author

Reproduction link?

Well, the same as for gomod: renovate-testing/test-27775-go-get-multiple-deps#1

Can't provide it separately, without particular caller implementation

@rarkins
Copy link
Collaborator

rarkins commented May 13, 2024

ℹ️ Artifact update notice

@zharinov
Copy link
Collaborator Author

ℹ️ Artifact update notice

renovate-testing/test-27775-go-get-multiple-deps#1 (comment)

@zharinov zharinov requested review from rarkins and viceice May 13, 2024 12:28
@zharinov
Copy link
Collaborator Author

Could we merge this one?

@rarkins rarkins added this pull request to the merge queue May 16, 2024
Merged via the queue into renovatebot:main with commit 1c8eb34 May 16, 2024
35 checks passed
@rarkins rarkins deleted the feat/artifact-notice-comments branch May 16, 2024 10:02
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.366.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants