feat: add datasource for AWS Lambda Layers #28251
Draft
+327
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
…ed-arn-datasource
…apag-Lloyd/renovate into kayma/add-aws-versioned-arn-datasource
…oned-arn-datasource
|
Reopens #19081 I stopped working on that PR because I found out that you usually do not have the
aws lambda add-layer-version-permission \
--layer-name my-layer \
--statement-id xaccount \
--action lambda:ListLayerVersions \
--principal 123456789012 \
--version-number 1 |
|
Still have to work on the documentation |
|
Todo: test this on a real repository |
viceice
requested changes
Apr 22, 2024
|
|
||
| @cache({ | ||
| namespace: `datasource-${AwsLambdaLayerDataSource.id}`, | ||
| key: (serializedLayerFilter: string) => |
There was a problem hiding this comment.
wrong, parameters are same as the function parameters below
Comment on lines
+55
to
+57
| const filter: AwsLambdaLayerFilter = JSON.parse( | ||
| serializedLambdaLayerFilter | ||
| ); |
There was a problem hiding this comment.
this should be done inside the function call below
| import { Datasource } from '../datasource'; | ||
| import type { GetReleasesConfig, ReleaseResult } from '../types'; | ||
|
|
||
| export interface AwsLambdaLayerFilter { |
There was a problem hiding this comment.
use zod Schema parsing to validate user input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new datasource to update the versioned layer arns for AWS Lambda Layers.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: