Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config)!: experimental flags #28187

Open
wants to merge 193 commits into
base: v38
Choose a base branch
from
Open

feat(config)!: experimental flags #28187

wants to merge 193 commits into from
+392 −78

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Mar 30, 2024 •
edited

Changes

  • Converted all experimental env vars of type:boolean to experimental flags.
  • Added validation for both experimentalFlags
  • Added a new function, validateExperimentalFlag which has a list of allowedExperimentalFlags object which we use to check for invalid flags
  • Updated the self-hosted-configuration.md file to include information about the new experimentalFlags options.
  • Created a new doc file in the self-hosted-experimental-flags.md file for the experimental flags.
  • Added a new method getExperimentalFlag in the GlobalConfig which checks whether flag is set.

List of new flags:

Experimental Env Var Experimental Flag
RENOVATE_X_DISABLE_DOCKER_HUB_TAGS disableDockerHubTags
RENOVATE_X_EXEC_GPID_HANDLE execGpidHandle
RENOVATE_EXPERIMENTAL_NO_MAVEN_POM_CHECK noMavenPomCheck
RENOVATE_X_NUGET_DOWNLOAD_NUPKGS nugetDownloadNupkgs
RENOVATE_PAGINATE_ALL paginateAll
RENOVATE_X_REBASE_PAGINATION_LINKS rebasePaginationLinks
RENOVATE_X_REPO_CACHE_FORCE_LOCAL repoCacheForceLocal
RENOVATE_X_SUPPRESS_PRE_COMMIT_WARNING suppressPreCommitWarning
RENOVATE_X_YARN_PROXY yarnProxy
RENOVATE_X_USE_OPENPGP useOpenpgp

Context

Closes: #27879

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh mentioned this pull request Mar 30, 2024
Open
viceice
viceice reviewed Mar 30, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

docs/usage/self-hosted-experimental.md Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Apr 6, 2024
View reviewed changes
docs/usage/self-hosted-experimental-flags.md Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
lib/util/experimental-flags.ts Outdated Show resolved Hide resolved
RahulGautamSingh and others added 5 commits April 7, 2024 16:42
@RahulGautamSingh @viceice
Update lib/util/experimental-flags.ts
6ee7872 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh @viceice
Apply suggestions from code review
87ac66b 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh
add tests
15a8720
@RahulGautamSingh
refactor
d0baeca
@RahulGautamSingh
Merge branch 'main' into refactor/experimental-flags
5f3ad4d
HonkingGoose
HonkingGoose suggested changes Apr 8, 2024
View reviewed changes
docs/usage/self-hosted-experimental-flags.md Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental-flags.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title refactor: experimental flags feat: experimental flags Apr 9, 2024
rarkins and others added 10 commits May 19, 2024 18:03
@rarkins
feat(packageRules)!: support glob/regex patterns for matchPackageNames (
6790556 
renovatebot#28551)
@viceice @rarkins
build!: drop compatibility from docker image (renovatebot#28588)
18be80b
@AaronMoat @rarkins
feat(git)!: determine branch modification based on all branch commits (…
917bc18 
…renovatebot#28225)
@rarkins @viceice
feat(packageRules)!: support regex or glob matching for all (renovate…
5f2155c 
…bot#28591)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins
feat(npm)!: remove RENOVATE_CACHE_NPM_MINUTES (renovatebot#28715)
3be8898
@RahulGautamSingh @rarkins
test: update wrong assertion (renovatebot#28741)
36e5987
@rarkins
chore(deps): update dependency @types/node to v20
7a93e64
@RahulGautamSingh @rarkins
refactor(vulnerability-alerts): move to REST API (renovatebot#27378)
8d91d6a
@rarkins @secustor @viceice
feat(packageRules): migrate matchers and excludes (renovatebot#28602)
f9bdc3a 
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@RahulGautamSingh @HonkingGoose @rarkins
feat(logging)!: drop logFile and logFileLevel (renovatebot#29104)
a7dc64f 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
viceice reviewed May 27, 2024
View reviewed changes
lib/config/global.ts Outdated Show resolved Hide resolved
lib/config/global.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/util/cache/package/index.ts Outdated Show resolved Hide resolved
lib/util/s3.spec.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeelsaabna nabeelsaabna Awaiting requested review from nabeelsaabna

@secustor secustor Awaiting requested review from secustor

@rarkins rarkins Awaiting requested review from rarkins

@viceice viceice Awaiting requested review from viceice

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert experimental env into globalOnly experimentalFlags
8 participants
@RahulGautamSingh @rarkins @viceice @secustor @HonkingGoose @nabeelsaabna @takac @AaronMoat