Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): override <GitHubBanner /> style #5964

Merged
merged 4 commits into from
May 23, 2024

Conversation

alicanerdurmaz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

feat: <GitHubBanner /> has paddingLeft: 200px by default to make space for the sidebar. This is not needed when the sidebar is not present.

What is the new behavior?

From on, <GitHubBanner /> style property can be overridden by passing containerStyle prop.

<GitHubBanner containerStyle={{ paddingLeft: 0 }} />

@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner May 19, 2024 00:29
Copy link

changeset-bot bot commented May 19, 2024

🦋 Changeset detected

Latest commit: 3428e66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alicanerdurmaz alicanerdurmaz added this to the June Release milestone May 19, 2024
Copy link

netlify bot commented May 19, 2024

Deploy Preview for refine-video-club failed.

Name Link
🔨 Latest commit e1f7e76
🔍 Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/664947f5a014600008f9d36c

@alicanerdurmaz alicanerdurmaz changed the base branch from master to releases/june May 19, 2024 00:30
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5964 May 19, 2024 00:35 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5964 May 19, 2024 00:35 Inactive
Copy link

cypress bot commented May 19, 2024

Passing run #11111 ↗︎

0 44 0 0 Flakiness 0

Details:

Merge 3428e66 into c1b12ab...
Project: refine Commit: b8e9712b37 ℹ️
Status: Passed Duration: 15:46 💡
Started: May 22, 2024 3:13 PM Ended: May 22, 2024 3:28 PM

Review all test suite changes for PR #5964 ↗︎

@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5964 May 19, 2024 12:19 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5964 May 19, 2024 12:20 Inactive
Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update any examples?

@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5964 May 20, 2024 11:11 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5964 May 20, 2024 11:12 Inactive
@BatuhanW BatuhanW merged commit 299cf59 into releases/june May 23, 2024
90 checks passed
@BatuhanW BatuhanW deleted the fix/override-gh-banner-style branch May 23, 2024 06:46
@aliemir aliemir mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants