-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth page): i18n key in register page for "haveAccount" #5816 #5914
base: master
Are you sure you want to change the base?
Conversation
|
Hello @keremilhan, thanks for the PR 🚀 This bug has been around for 1 year. Unfortunately, if we do this Fix, it becomes a breaking change and we need to release a Major release. It would be inefficient to release a major just for this. Alternatively, we can do something like this: {translate("pages.register.buttons.haveAccount") ?? translate(
"pages.login.buttons.haveAccount",
"Have an account?",
)} or {
translate(
"pages.register.buttons.haveAccount",
translate("pages.login.buttons.haveAccount", "Have an account?"),
);
} I haven't tested if these codes work or not, I will test them when I have time. What I mean is that we need to somehow support this key "pages.login.buttons.haveAccount" in order not to break the application of users who are currently using Refine, and this should work in different |
Hi @alicanerdurmaz, thanks for your quick reply. I understand the situation very well. If there is something I can do as a fresh contributor, I would be glad to help. I will be around to solve the issues with the "good first issue" tag :) |
@keremilhan Thanks for improving Refine. If you want to continue working on this, please write something in the issue post (ex: I want to work on this) and I will assign you this issue. |
Hello again @keremilhan, will you be able to find time to continue with the PR? |
Hello again @keremilhan, Refine follows a monthly release cycle. We're releasing a new version every month with the changes we've made in that month. So, if you want this development to be released in the first week of June, we have little time left 🙌 |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Register pages use login pages' key for "haveAccount". =>
pages.login.buttons.haveAccount
What is the new behavior?
Register pages are now using register pages' key for "haveAccount". =>
pages.register.buttons.haveAccount
fixes # (issue)
#5816
Notes for reviewers