Optimize zunion[store] command by avoiding the duplicate copy of dict #13155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past
zunion
andzunionstore
command, we first constructed aaccumulator
dict and then converted it into the final sorted set. But we can use the dict indstobj
directly to avoid the cost of constructing a new dict during converting to improve performance.In this PR, I removed the
accumulator
dict and replace it with the dict indstobj
.I made a test on
zunion
andzunionstore
command. I first add two zsets each with 100 unique elements. Then I callzunion
orzunionstore
on these zsets. The result shows the performance can improve about 18%.zunion
unstable
This PR
zunionstore
unstable
This PR