Update to put a more clear message about the requirement of Java 8 #3797
Conversation
|
@otaviojava Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@otaviojava Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@otaviojava Thank you for signing the Contributor License Agreement! |
| @@ -15,7 +15,7 @@ Since `3.3.x`, this repository also contains `reactor-tools`, a java agent aimed | |||
|
|
|||
| ## Getting it | |||
|
|
|||
| **Reactor 3 requires Java 8 or + to run**. | |||
| **The Minimum requirement for Reactor 3 is Java 8 or higher**. | |||
There was a problem hiding this comment.
Thanks for the suggestion. I'm not a native English language speaker so I might not know best, but it feels like the proposed sentence is not as concise and the caps/non-caps are not consistent. Why would "Minimum" be capitalized? To be honest, the current flow of the sentence makes more sense to me. Would "Reactor 3 requires Java 8 or higher to run" be acceptable? This way, only the "+" sign is replaced with "higher" and maintains the conciseness.
It is a minor enhancement at the readme about the minimum requirement of Java 8.