Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @rneui/layout #3648

Draft
wants to merge 20 commits into
base: next
Choose a base branch
from

Conversation

arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Oct 1, 2022

@bartvanandel
Copy link

We've been using that package in a WIP app, but we switched to a custom View component instead after running into too many issues with this package. I haven't kept a list unfortunately, but we did find that changing styling of a parent component could cause items to disappear from the screen when using <Stack /> for instance. I wouldn't consider this production ready (hence the alpha in the version, presumably).

One reason for adding this package though would be that some of the examples rely on it, and don't actually work without it currently.

@arpitBhalla arpitBhalla marked this pull request as draft October 3, 2022 13:20
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #3648 (20b4243) into next (f5f5812) will decrease coverage by 0.57%.
The diff coverage is 57.44%.

❗ Current head 20b4243 differs from pull request most recent head ab9dfb7. Consider uploading reports for the commit ab9dfb7 to get more accurate results

@@            Coverage Diff             @@
##             next    #3648      +/-   ##
==========================================
- Coverage   79.42%   78.85%   -0.58%     
==========================================
  Files          87       93       +6     
  Lines        1823     1868      +45     
  Branches      806      836      +30     
==========================================
+ Hits         1448     1473      +25     
- Misses        370      390      +20     
  Partials        5        5              
Impacted Files Coverage Δ
packages/layout/src/Grid/Grid.tsx 0.00% <0.00%> (ø)
packages/layout/src/Grid/GridItem.tsx 0.00% <0.00%> (ø)
packages/layout/src/Grid/index.tsx 0.00% <0.00%> (ø)
packages/layout/src/Stack/index.tsx 0.00% <0.00%> (ø)
packages/layout/src/Box/index.tsx 100.00% <100.00%> (ø)
packages/layout/src/system/makeStyles.ts 100.00% <100.00%> (ø)
packages/base/src/Tab/Tab.tsx 57.14% <0.00%> (-3.18%) ⬇️
packages/base/src/Avatar/Avatar.tsx 97.22% <0.00%> (ø)
packages/base/src/Button/Button.tsx 90.66% <0.00%> (ø)
packages/base/src/Switch/Switch.tsx 100.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla
Copy link
Member Author

Hey @bartvanandel, I just release another alpha for this pkg, would it be possible for you to test Stack and Box component?

@arpitBhalla arpitBhalla linked an issue Apr 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Component in Documentation
2 participants