Fix SetError to Preserve Existing Errors elsewhere in the object #11888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling setError, if a call was made to set an error on a descendant within a form (
foo.bar.baz
), then a later call was made to set an error on the ancestor (foo.bar
), the previous error would be lost.This was the run of
pnpm test
after the first commit, which only contained the test:Following the update to
setError
, we make sure you don't lose the errors that are further down the tree by including them in the call to set. To be fair, one /could/ consider just spreading in the entirecurrentError
, but by destructuring and omittingmessage
andtype
we make sure that they get overwritten by the current error.