Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax start/end date formats #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexnikitchuk
Copy link

What

fix for #360

How

Use default click.DateTime formats %Y-%m-%d, %Y-%m-%dT%H:%M:%S, %Y-%m-%d %H:%M:%S

@stevenayers
Copy link

@mateuszklimek This feature would be useful - I'm running my notification every 15 minutes. Any chance we could get it merged?

@davidzajac1
Copy link
Collaborator

@alexnikitchuk @stevenayers sorry for the hold up on this one. I ran our setup_toy_shop.sh shell script we use to test changes but I changed one of the commands to use %Y-%m-%d %H:%M:%S format and got the following error:

Error: Invalid value for '--start-date': '2021-01-07 11:00:00' does not match the format '%Y-%m-%d'

Looks like there is probably some other datetime related changes needed in the command_line.py file. Also I updated our CONTRIBUTING.md to make it easier for anyone to run these tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants