Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow static builds to work with clang and no coordgen #7416

Merged
merged 1 commit into from
May 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions External/CoordGen/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ if(RDK_BUILD_COORDGEN_SUPPORT)
rdkit_library(coordgen ${CGSOURCES} SHARED)
if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
target_compile_options(coordgen PUBLIC -Wno-unused-but-set-variable)
if(RDK_INSTALL_STATIC_LIBS)
target_compile_options(coordgen_static PUBLIC -Wno-unused-but-set-variable)
endif()
endif()
install(TARGETS coordgen DESTINATION ${RDKit_LibDir})
set(RDK_COORDGEN_LIBS coordgen CACHE STRING "the external libraries" FORCE)
Expand Down