Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

make things work with pandas 2.2 #7226

Merged
merged 3 commits into from Mar 10, 2024
Merged

Conversation

greglandrum
Copy link
Member

@greglandrum greglandrum commented Mar 9, 2024

Finishes what was started in #7165


馃摎 Documentation preview 馃摎: https://rdkit--7226.org.readthedocs.build/en/7226/

@greglandrum greglandrum added bug not in release notes a change that doesn't need to go in the release notes labels Mar 9, 2024
Copy link
Contributor

@ptosco ptosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this, and apologies for not having checked earlier that #7165 was actually working on pandas >2.2.

@ptosco
Copy link
Contributor

ptosco commented Mar 10, 2024

@greglandrum I checked that the fix also works for me, and I submitted a PR against your branch which also fixes an annoying deprecation warning which occurs since pandas 2.1.0:
greglandrum#22

Suppress a deprecation warning in pandas >= 2.1.0
@greglandrum greglandrum merged commit 462ed8f into rdkit:master Mar 10, 2024
11 checks passed
@greglandrum greglandrum modified the milestones: 2024_09_1, 2024_03_1 Mar 10, 2024
@greglandrum greglandrum deleted the fix/pandas_2.2 branch April 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug not in release notes a change that doesn't need to go in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants