New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Stereochemistry canonicalization errors #7041
Open
tadhurst-cdd
wants to merge
85
commits into
rdkit:master
Choose a base branch
from
cdd:pseudoChiralCanonError
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get the tests passing on linux and the psql results updated
…eudoChiralCanonError
@tadhurst-cdd this looks like a very nice change. It looks like this may go towards fixing an issue I recently reported #7266 |
Addressed changes to fix errors in tests provided by Greg Landrum. There were a couple of fixes, and the code now does NOT throw an error is the enhanced procedure does not work, but simply calls the old canonicalization method |
…eudoChiralCanonError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Enhanced Stereochemistry canonicalization errors
What does this implement/fix? Explain your changes.
Many compounds can be formulated as smiles with different enhanced stereochemistry specification but are actually the same compound. For example:
These are all the same, but without the new code, generate different canonical smiles
These are also the same:
Any other comments?