Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conan build 97% success #6850

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

conan build 97% success #6850

wants to merge 9 commits into from

Conversation

HokageM
Copy link

@HokageM HokageM commented Oct 29, 2023

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

@HokageM
Copy link
Author

HokageM commented Oct 29, 2023

Make sure freetypes is properly installed on your device (look at r-lib/ragg#86)

@HokageM
Copy link
Author

HokageM commented Oct 29, 2023

conan create . -o *:without_python=False --build=missing -s build_type=Debug

@greglandrum
Copy link
Member

@HokageM thanks for thinking about doing this and putting in the effort. Please let me know when you think the PR is ready to review (and when all the CI builds are passing).
After a quick skim, I do have some feedback on this:

  1. We aren't going to change default configuration settings unless there's a good argument for it.
  2. The current minimal boost version could (and probably should be updated), but we are very conservative about this kind of update (since we know that there a people building the RDKit on older operating systems) and likely won't take anything that's not at least a couple of years old without a very good reason.

@nikplx nikplx deleted the conan branch October 31, 2023 10:37
@nikplx nikplx restored the conan branch October 31, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants