-
Notifications
You must be signed in to change notification settings - Fork 845
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- remove valences which are inconsistent with periodic table group me…
…mbership Al(IIIb), Si(IVb), P(Vb), As(Vb), Sb(Vb), Bi(Vb) - address elements with d orbitals (P, As, Sb, Si) which can accommodate bonds supported by lone pairs from halogens and chalcogens with requiring adding extra valences to periodic table - add test to make sure that PX6-, AlX63-, AsX6-, SbX6-, BiF6- do not raise an AtomValenceException while PX6, AlX6, AsX6, SbX6, BiX6 and peracids of the same elements which cannot exist raise an AtomValenceException - correct SmilesTests.java and rdkit/Chem/UnitTestSmiles.py where CCC[Al+3] should rather read CCC[Al+2] - comment out incorrect entries in rdkit/Chem/test_data/NCI_aromat_regress.txt and rdkit/Chem/test_data/NCI_5K_TPSA.csv - add -1 valence to alkali elements which were missing it (Rb, Cs, Fr)
- Loading branch information
ptosco
committed
May 1, 2024
1 parent
187d2ca
commit 2d2ac12
Showing
7 changed files
with
139 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.