Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ruby client #89

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: ruby client #89

wants to merge 7 commits into from

Conversation

davalpargal
Copy link

Ruby client with current capability to:

Fetch descriptors from a single url.
Cache descriptors with a ttl.
Fetching proto descriptor using proto class name.

@ravisuhag ravisuhag changed the title feat/ruby client feat: ruby client Dec 2, 2021
@h4rikris h4rikris self-requested a review December 2, 2021 10:57
@h4rikris h4rikris linked an issue Dec 2, 2021 that may be closed by this pull request
Add ruby client for stencil #69
Open
@h4rikris
Copy link
Member

h4rikris commented Dec 2, 2021

Hi @davalpargal, thanks for the PR.

Can you add ruby client gem publishing via github workflow as well to this PR?

@davalpargal davalpargal force-pushed the feat/ruby-client branch 4 times, most recently from 1262336 to 4e60bbc Compare December 6, 2021 03:54
@davalpargal
Copy link
Author

davalpargal commented Dec 6, 2021 •
edited

Hi @davalpargal, thanks for the PR.

Can you add ruby client gem publishing via github workflow as well to this PR?

Hey @harikrishnakanchi ! Do we have an existing rubygem account or lets pair to create one

@h4rikris
Copy link
Member

@ravisuhag can you help creating rubygem account?

@ravisuhag
Copy link
Member

@harikrishnakanchi @davalpargal created an account and added secret RUBYGEMS_TOKEN Feel free to use this in the workflow.

@ravisuhag
Copy link
Member

@harikrishnakanchi @davalpargal created an account and added secret RUBYGEMS_TOKEN Feel free to use this in the workflow.

@harikrishnakanchi @davalpargal Can you folks please try it out and see if we are able to publish it?

ravisuhag
ravisuhag reviewed Jan 18, 2022
View reviewed changes
.github/workflows/release.yml
gem build *.gemspec
gem push *.gem
env:
GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davalpargal Typo here. Secret name is RUBYGEMS_TOKEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag ravisuhag left review comments

@h4rikris h4rikris Awaiting requested review from h4rikris

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ruby client for stencil
3 participants
@davalpargal @h4rikris @ravisuhag