[rcore] Manage access to CORE.Window through a macro to make multi-window branch easier to update
#3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter0x44
reviewed
May 11, 2024
raysan5
changed the title
CORE.Window through a macro to make multi-window branch easier to update
raysan5
reviewed
May 16, 2024
| @@ -302,6 +302,76 @@ | |||
| </Link> | |||
| </ItemDefinitionGroup> | |||
| <ItemGroup> | |||
| <ClCompile Include="..\..\..\src\platforms\rcore_android.c"> | |||
There was a problem hiding this comment.
Why are those files required? I don't need them on my VS2022 project solution...
There was a problem hiding this comment.
They are not required. Having them in the solution and marked as non buildable simply makes them easy to find and edit from within the IDE, instead of having to go find the files. It's purely a convenience feature for working in visual studio.
I can remove them if desired.
| @@ -0,0 +1,62 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Why are those files required? I don't need them on my VS2022 project solution...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a subtle but pervasive change to the platform system. It routes access to the Core.Window structure through a new macro named CORE_WINDOW.
The reason for this is to help out the multi-window branch in raylib-extras.
To make this branch work, it needs a window structure per window. Right now I have to manually replace all calls to CORE.Window with CORE.Window[GetActiveWindow()], and everytime raylib updates things break. With this change, the branch can simply replace the CORE_WINDOW macro in one place and not have to hit all the places in the code and all platforms.
This change has ZERO benefit to regular raylib, and thus I understand if it's too pervasive, It would just make multi-window easier to keep in sync with main raylib.