add links to eks site for neuron examples #45341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyscalesam
added
docs
angelinalg
approved these changes
May 14, 2024
| @@ -26,7 +26,7 @@ The accelerators natively supported by Ray Core are: | |||
| - Experimental, supported by the community | |||
| * - `AWS Neuron Core <https://awsdocs-neuron.readthedocs-hosted.com/en/latest/general/arch/model-architecture-fit.html>`_ | |||
| - neuron_cores | |||
| - Experimental, supported by the community | |||
| - Experimental, supported by the community. See examples on AWS EKS `here <https://awslabs.github.io/data-on-eks/docs/gen-ai>`_ | |||
There was a problem hiding this comment.
Suggested change
| - Experimental, supported by the community. See examples on AWS EKS `here <https://awslabs.github.io/data-on-eks/docs/gen-ai>`_ | |
| - Experimental, supported by the community. See `Generative AI on EKS <https://awslabs.github.io/data-on-eks/docs/gen-ai>`_ for examples. |
There was a problem hiding this comment.
Thanks for adding the link. We try to avoid using "here" for links because it's not very descriptive. Would you mind installing Vale, which will catch these style nuances? go/vale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding some links to examples for running Ray on Neuron on EKS.
Related issue number
None.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.