[core] Deflake windows://python/ray/tests:test_get_locations by reducing object size
#45309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
changed the title
windows://python/ray/tests:test_get_locations by reducing mem cost in ci
rynewang
changed the title
windows://python/ray/tests:test_get_locations by reducing mem cost in ciwindows://python/ray/tests:test_get_locations by reducing object size in ci
|
@jjyao windows test passed, let's merge this and deflake |
rynewang
changed the title
windows://python/ray/tests:test_get_locations by reducing object size in ciwindows://python/ray/tests:test_get_locations by reducing object size
jjyao
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test failure CI, I find this log:
So maybe it's using too much mem and windows got OOM. Reducing the object size in CI.
Fixes #45278