-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Add support for objects to Arrow blocks #45272
Open
terraflops1048576
wants to merge
7
commits into
ray-project:master
Choose a base branch
from
terraflops1048576:terraflops/add_objects_to_arrow_blocks
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Data] Add support for objects to Arrow blocks #45272
terraflops1048576
wants to merge
7
commits into
ray-project:master
from
terraflops1048576:terraflops/add_objects_to_arrow_blocks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
terraflops1048576
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
May 11, 2024 22:24
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
terraflops1048576
force-pushed
the
terraflops/add_objects_to_arrow_blocks
branch
from
May 12, 2024 05:46
abe7c58
to
516ff57
Compare
…fix type annnotation Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
terraflops1048576
force-pushed
the
terraflops/add_objects_to_arrow_blocks
branch
from
May 12, 2024 05:59
516ff57
to
3b38131
Compare
terraflops1048576
changed the title
Add support for objects to Arrow blocks
[Data] Add support for objects to Arrow blocks
May 12, 2024
terraflops1048576
force-pushed
the
terraflops/add_objects_to_arrow_blocks
branch
2 times, most recently
from
May 12, 2024 19:23
2d82297
to
978b30e
Compare
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
terraflops1048576
force-pushed
the
terraflops/add_objects_to_arrow_blocks
branch
from
May 12, 2024 20:26
978b30e
to
014949f
Compare
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
@terraflops1048576 this could be a big contribution but we want to think a little deeper about this with you to properly codevelop this; can you reach out to me on Ray Slack so we can setup some time to discuss further. My handle is "Sam (Ray Team)" We should get a formal REP in ray-enhancements for this as well: https://github.com/ray-project/enhancements cc @bveeramani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, Ray does not support blocks/batches with objects and multi-dimensional arrays in different columns. This causes Ray Data to throw exceptions when these are provided because:
return pd.DataFrame(dict(batch))
inBlockAccessor.batch_to_block
.This change enables Python object storage in the Arrow blocks by defining an Arrow extension type that simply represents the Python objects as a variable-sized large binary. I suppose the alleged performance benefits listed in the comments are an extra benefit.
I'm not sure that this is the correct approach or that I've properly patched all of the places, so some help would be appreciated!
Related issue number
Resolves #45235
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.