grid_search resolution code optimization #45267
Open
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Dyro <rdyro@stanford.edu>
matthewdeng
approved these changes
May 21, 2024
Comment on lines
428
to
433
| # a skeleton is easier to copy for every iteration | ||
| unresolved_spec_skeleton = copy.deepcopy(unresolved_spec) | ||
| for path, _ in grid_vars: | ||
| assign_value(unresolved_spec_skeleton, path, None) | ||
| while value_indices[-1] < len(grid_vars[-1][1]): | ||
| spec = copy.deepcopy(unresolved_spec) | ||
| spec = copy.deepcopy(unresolved_spec_skeleton) |
There was a problem hiding this comment.
Could you clarify the comments here to describe what's happening in each step? Specifically I think it would be good to explain what the "skeleton" is (i.e. the spec with the grid_vars set to none), and then within the while loop comment that we are populating the values for a single variant.
There was a problem hiding this comment.
That's a great suggestion; I'll add the comments ASAP.
There was a problem hiding this comment.
Let me know if that's what you had in mind or if you have any feedback.
…ere values are going to be filled Signed-off-by: Robert Dyro <rdyro@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small Python code optimization to significantly speed up
grid_searchresolution.Instead of deep-copying the whole unresolved spec for every resolved spec, we can create a skeleton spec, filled with None in place of grid variables, and deep-copy that every time. The fix involves a handful of line changes in one location.
I checked that the slow implementation is still present in the latest release.
Why are these changes needed?
The current grid resolution takes upwards of 1 minute on a Ryzen 7 7600X for grid_search generation for grids larger than 10k elements. Ray does not start the trials before generating the entire grid and the behavior, resulting from slow grid resolution, appears like ray has hung (as the trials are not starting) - this is confusing.
Related issue number
N/A
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.