Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for 'arm64' and 'armhf' #285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hwittenborn
Copy link

@hwittenborn hwittenborn commented Sep 12, 2023

See hwittenborn/rathole#6142076855 for the test run I did with these changes. Also note that the commit used in that run has been removed from a force push (to allow this PR to be made), though the commit can be found here: hwittenborn/rathole:9c5e606e7f3ff52e36b63c26d5851fcf0f5715b9.

I have cargo being installed via apk as the rust:alpine image doesn't currently build for the linux/armhf Docker platform (see rust-lang/docker-rust#142).

Closes #141.

@hwittenborn
Copy link
Author

I'm getting a local issue where there's some missing libraries in the built image - I'm not sure if it's just something on my machine, but I thought it should be mentioned in case it needs to get looked at before a merge.

@rapiz1 rapiz1 force-pushed the main branch 8 times, most recently from 78f1157 to 97541af Compare October 1, 2023 09:13
@rapiz1
Copy link
Owner

rapiz1 commented Oct 1, 2023

I'm getting a local issue where there's some missing libraries in the built image

Hey, can you elaborate on that? Is it TLS related?

BTW, @rucciva has changed the dockerfile to another base, which should solve the TLS problem. Would you mind test it again? It will be great to publish docker image for arm platforms.

Thanks for looking into this!

@hwittenborn
Copy link
Author

Thanks for the update @rapiz1!

Hey, can you elaborate on that? Is it TLS related?

I haven't needed the images outside of amd64 as of recent (I needed armhf previously for my raspberry PI, which I no longer use), and I've since forgotten on the specifics that was causing the breakage.

BTW, @rucciva has changed the dockerfile to another base, which should solve the TLS problem.

Went ahead and did that, let me know if there's anything else that'd need to be done. This PR's pretty tiny at this point too, so feel free to just make the changes yourself if there's something else that needs fixed up.

@rapiz1
Copy link
Owner

rapiz1 commented Oct 1, 2023

Unfortunately I don't have a platform to test this as well :(

@hwittenborn
Copy link
Author

I do have the Raspberry Pi still @rapiz1, I won't be able to use it until tomorrow but I can get this all tested then.

@Freekers
Copy link

Freekers commented Oct 7, 2023

Unfortunately I don't have a platform to test this as well :(

Oracle offers a free ARM Based VPS on their Free Tier. Might come in handy in case you don't have an ARM based platform to test on :) Alternatively, Hetzner offers an ARM based VPS as low as € 0.007 / hour.

@@ -155,6 +155,7 @@ jobs:
uses: docker/build-push-action@v2
with:
push: true
platforms: "linux/amd64,linux/arm64,linux/armhf"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added armv7 (common SBCs like raspberry pi or odroid). Also, " are not needed

Suggested change
platforms: "linux/amd64,linux/arm64,linux/armhf"
platforms: linux/amd64, linux/arm64, linux/armhf, linux/armv7

@rapiz1
Copy link
Owner

rapiz1 commented Feb 14, 2024

@sunmy2019 this is a low hanging fruit that could be very useful to many users. It would be great if you're able to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

能否提供一下 docker arm 的镜像?
4 participants