-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix threads implementation #685
base: dev
Are you sure you want to change the base?
Conversation
* Retries with backoff * Normalize output for single tickers * Remove the shared dfs, prune to race conditions
@jrdi Although I agree with your new implementation, it would be great if you could provide (at least) 1 example which was failing without your fix and now works with it. |
731fecd
to
4734e92
Compare
@fredrik-corneliusson I believe you are a heavy user of |
Yes I think the threads implementation would be in need of a improvement, any exceptions raised in threads results in the whole download hanging. |
I'm not sure if this issue is local to the machine I was working with (M1 Macbook Pro, macOS 13.5 Ventura, Python 3.11.4), but for large downloads (7000+ tickers over 2 years), I get I fixed the issue by implementing a |
Anyone can submit a pull request, just saying. |
I invested some time fixing the threads implementation and also adding other improvements such as:
I'd appreciate it if you can provide some feedback.