(#244) Fix .info['annualReportExpenseRatio'] for ETFs #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #244, there is a bug with querying for an ETF's
expense ratio. For mutual funds, this value is found in
.info['annualReportExpenseRatio']
, but for ETFs it is not.The github user @ycc1107 commented on the issue, identifying the root
cause, which is that for some reason this value is only available inside
the
'fundProfile'
key of thedata
dictionary, a key that is onlypresent when querying mutual funds and ETFs.
The
'fundProfile'
key leads to a dictionary with a'feesExpensesInvestment'
key, which leads to a dictionary with an'annualReportExpenseRatio'
key, which has the value we need.The github user @ycc1107 opened a PR to fix this issue, but I'm
concerned that it changes too much, as it recursively merges the
entirety of the
'fundProfile'
dictionary into the.info
dictionary.So I'm proposing an alternative fix here that attempts to write only
.info['annualReportExpenseRatio']
and nothing else.