Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For ETFs & Mutual Funds, add fundProfile & fundPerformance details #1159

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

thirumalairajr
Copy link
Contributor

Hi,

This change will add support for showing fundProfile & fundPerformance of ETFs and Mutual Funds.

fundProfile will add support for useful fields like

  • family
  • categoryName
  • brokerages
  • managementInfo
  • feesExpensesInvestment
  • feesExpensesInvestmentCat

fundPerfomance will add support for useful fields like

  • trailingReturns
  • trailingReturnsCat
  • trailingReturnsNav
  • performanceOverview
  • performanceOverviewCat
  • riskOverviewStatistics
  • riskOverviewStatisticsCat
  • rankInCategory
  • loadAdjustedReturns
  • pastQuarterlyReturns
  • annualTotalReturns
  • returnsCat

@ValueRaider
Copy link
Collaborator

This is fine, but we have temporarily frozen dev branch for new features while @fredrik-corneliusson refactors base.py (work in progress). We expect to unfreeze with a week.

@thirumalairajr
Copy link
Contributor Author

Sure that works !!

@ValueRaider
Copy link
Collaborator

dev is open now, so when you handle the conflict I can merge. Conflict caused by recent major refactor so be careful.

@fredrik-corneliusson
Copy link
Contributor

@thirumalairajr
Copy link
Contributor Author

@fredrik-corneliusson Sure I will make the changes

@thirumalairajr
Copy link
Contributor Author

@ValueRaider I have resolved the merge conflicts.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Nov 21, 2022

Code is fine. I've examined info[] for first time and see some new entries are time-series data - trailingReturns, annualTotalReturns, pastQuarterlyReturns. These should go in a Pandas table, can you implement that?

An alternative is blacklist those keys with a comment and someone else implement in future. And maybe just add most recent value of each.

@thirumalairajr
Copy link
Contributor Author

thirumalairajr commented Nov 22, 2022

@ValueRaider I can implement the pandas way as I see value in that approach. Adding only the recent value of each might not be useful as this data is consumed with history.

But I don't think trailingReturns is a time-series data , the access pattern for this would be mostly key-based lookup for getting 10 year , 5 year returns etc.,

I can create annual_total_returns, past_quarterly_returns functions to return annualTotalReturns & pastQuarterlyReturns data as dataframe. Shall I start working on it?

@ValueRaider
Copy link
Collaborator

Ah you're right on trailingReturns, I must have got mixed up.

Go ahead with Pandas.

@ValueRaider
Copy link
Collaborator

Abandoned. Anyone want to take over and finish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants