-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option filter
on in_order_of
#51761
Open
igordepolli
wants to merge
9
commits into
rails:main
Choose a base branch
from
igordepolli:option-only-values-on-in-order-of
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add option filter
on in_order_of
#51761
igordepolli
wants to merge
9
commits into
rails:main
from
igordepolli:option-only-values-on-in-order-of
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
I really like this idea, I had already the same, but you are faster ;) Maybe
|
@timoschilling, ty very much for your review! I liked your idea, @admsev , thanks for the bot suggestions as well! I made the grammar correction and the other consistency correction it suggested! |
igordepolli
changed the title
Add option
Add option May 28, 2024
only_values
on in_order_of
filter
on in_order_of
Co-authored-by: Timo Schilling <timo@schilling.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because currently,
in_order_of
method always use where clause to filter the results only with the values specified invalues
. Sometimes, we only want to put some values as priority in the sorting but we want the entire search scope without caring about the rest of the sorting. The propose here is add an option to specify to filter scope by values or not.Detail
This Pull Request changes:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]