Make extract! accept objects with internal hash implementation

[bacchir]

In a recent project I've experienced an odd situation of having an object that implements some Hash behavior and, even though it has methods such as [] and fetch, jbuilder.extract! did not work with it. So I just created this little PR with some tests to make jbuilder more agnostic.

Here's an example (also used in the tests) of the object I'm trying to pass to jbuilder:

class PersonWithHash
  attr_reader :name, :collection

  def initialize(name, age)
    @collection = { age: age }
    @name = name
  end

  delegate :[], :fetch, to: :@collection
end

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[robin850]

The risk is pretty low but still, it should rather be:

object.respond_to?(:fetch) ? object.fetch(attribute) : object.public_send(attribute)

Otherwise, if a hash or hash-like object has a :object_id, :hash or any of its method as a key, the wrong value may be returned.

Could you fix this and add a test to ensure that a Hash with such key would be properly handled please ?

[bacchir]

Sorry @robin850 I just saw your comment now. Sure I'll change it 😊

[bacchir]

@robin850 I changed the implementation the way you suggested, however I changed respond_to?(:fetch) to respond_to?(:[]) to avoid problems when an object have a custom fetch method for other purposes.