Namespacing directory generation fix #380
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rwz (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
nullset2
force-pushed
the
namespacing-directory-generation-fix
branch
from
5eab3af
to
1e1778c
Compare
|
Hey guys, sorry about dropping off this PR a while ago, I got stuck with a lot of stuff and I'm trying to pick it up now. The checks pass now and I think I have described the problem adequately and my approach works, however I'm willing to change stuff if you have feedback for me. Thanks dudes. |
| assert_match %r{json\.extract! api_foo, :id, :bar, :baz, :created_at, :updated_at}, content | ||
| assert_match %r{json\.url api_foo_url\(api_foo, format: :json\)}, content | ||
| end | ||
|
|
There was a problem hiding this comment.
Could you remove those blank lines?
There was a problem hiding this comment.
Do you mean the lines after 34 on the test?
….com/nullset2/jbuilder into namespacing-directory-generation-fix
|
@rafaelfranca do you have any additional input for this? |
See issue #379. Very quick contribution, the tests pass afaik, I used gsub on the templates because using that we'll avoid breaking the templates for un-namespaced scaffolding. I know there's probably a better way to do this but I think this is still usable though.