Update equality macro for recur and hash-code-combine #274

AlexKnauth · 2023-02-06T14:52:45Z

Changes from @jackfirth's original #270:

Rhombus unsyntax-splicing $$ is now just $
Rhombus assume-annotation -: is now :~
Equatable uses recur now
private implements Equatable is encouraged
Uses Rhombus's new hash_code_combine
Uses type tags in hash codes to distinguish different but similarly-shaped types
Adds tests

avoid using lib("racket/base.rkt").#{equal-hash-code} because that's wrong on mutable data

AlexKnauth mentioned this pull request Feb 6, 2023

Add an equality macro #270

Draft

AlexKnauth force-pushed the feature-equality-macro-2 branch from 06ef3ec to 4026df5 Compare February 7, 2023 16:28

jackfirth and others added 4 commits February 7, 2023 17:55

Draft an equality macro

1947bd4

Update equality method names / arities

37a0d03

Equality private implements, use recur, add tests

f52d98f

avoid using lib("racket/base.rkt").#{equal-hash-code} because that's wrong on mutable data

Use hash_code_combine and type-tag in hash_code

2026002

AlexKnauth force-pushed the feature-equality-macro-2 branch from 4026df5 to 2026002 Compare February 7, 2023 22:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update equality macro for recur and hash-code-combine #274

Update equality macro for recur and hash-code-combine #274

AlexKnauth commented Feb 6, 2023 •

edited

Update equality macro for recur and hash-code-combine #274

Are you sure you want to change the base?

Update equality macro for recur and hash-code-combine #274

Conversation

AlexKnauth commented Feb 6, 2023 • edited

AlexKnauth commented Feb 6, 2023 •

edited