Add list-update* and list-set*.
#4415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorawee
reviewed
Aug 26, 2022
racket/collects/racket/list.rkt
Outdated
| (unless (list? l) | ||
| (apply raise-argument-error 'list-update* "list?" 0 l pairs)) | ||
| (unless (even? (length pairs)) | ||
| (error 'list-update* "expected an even number of association elements, but received an odd number: ~e" pairs)) |
There was a problem hiding this comment.
IIUC, we should avoid using error, since it does not follow the error message conventions.
Here's how this kind of pairing errors are reported in racket/collects/racket/private/hash.rkt's paired-fold:
(raise-arguments-error
who
(format "expected ~a, but received ~a"
"an even number of association elements"
"an odd number of association elements")
"association elements"
pairs0)
sorawee
reviewed
Aug 26, 2022
racket/collects/racket/list.rkt
Outdated
| (unless (list? l) | ||
| (apply raise-argument-error 'list-set* "list?" 0 l pairs)) | ||
| (unless (even? (length pairs)) | ||
| (error 'list-set* "expected an even number of association elements, but received an odd number: ~e" pairs)) |
sorawee
reviewed
Aug 26, 2022
| (unless (exact-nonnegative-integer? (car p)) | ||
| (apply raise-argument-error 'list-set* "exact-nonnegative-integer?" i l pairs)) | ||
| (check (cddr p) (+ 2 i)))) | ||
| (define cache (apply hasheq pairs)) |
There was a problem hiding this comment.
I think there must be additional checks that all indices are in bound. Otherwise, you get:
> (list-set* '(1 2 3) 1000 1)
car: contract violation
expected: pair?
given: '()
1 task
shhyou
added
the
api design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.