Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi: add _delay ctype form #4173

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ffi: add _delay ctype form #4173

wants to merge 3 commits into from

Conversation

rmculpepper
Copy link
Collaborator

This adds a _delay form for ctypes, similar to recursive-contract for contracts.

Before merging:

  • The documentation should probably be moved to a different section, but I'm not sure which section would be best.
  • Remove FIXME from merge commit (or better, merge by squashing).

@rmculpepper rmculpepper requested a review from mflatt March 29, 2022 12:53
mflatt
mflatt approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@mflatt mflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I don't have a better idea for where to put the documentation, although maybe a link from the define-cstruct form's documentation would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflatt mflatt mflatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmculpepper @mflatt