Clarify use of @buffered
and only update content-length
when #finish
.
#2149
+19
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #2148.
I don't think
Rack::Response
should bother caching content length or update the header.falcon
never trusts the user suppliedcontent-length
header. Puma may? If the user supplied content length header is incorrect, it can be a major security issue.Therefore, I wonder if we should avoid manipulating the
content-length
header at all.This PR is just me trying out ideas, but maybe we can figure out a better solution.