Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap maybe function in quotes, so it is treated as an atom (backport #11251) #11266

Merged
merged 1 commit into from
May 20, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 17, 2024

Proposed Changes

Since maybe is added as an optional keyword in OTP 25, quote its usage as an atom, so that it does not break syntax highlighting and other language service features.

Types of Changes

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

This is an automatic backport of pull request #11251 done by [Mergify](https://mergify.com).

@michaelklishin michaelklishin added this to the 3.13.3 milestone May 17, 2024
@michaelklishin
Copy link
Member

michaelklishin commented May 17, 2024

Not merging yet until next week when a Tanzu RabbitMQ release ships, then we will be ready to re-start backports of PRs that change the code (that is, not the build system parts or docs, for example).

@michaelklishin michaelklishin merged commit 4e72084 into v3.13.x May 20, 2024
14 of 15 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-11251 branch May 20, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants